Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] clarifies 'in C-locale' #2387

Merged
merged 9 commits into from
Sep 27, 2017

Conversation

HughParsonage
Copy link
Member

Adds a sentence to man/setorder.Rd to close #1996.

@codecov-io
Copy link

codecov-io commented Sep 26, 2017

Codecov Report

Merging #2387 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
+ Coverage   91.24%   91.29%   +0.05%     
==========================================
  Files          62       62              
  Lines       11978    11978              
==========================================
+ Hits        10929    10935       +6     
+ Misses       1049     1043       -6
Impacted Files Coverage Δ
src/forder.c 94.47% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f422f5e...ac689b3. Read the comment docs.

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's not exactly true. I have in mind users for whom neither C nor R locales are English. Maybe worth clarifying ("commonly"/"in English locales"/etc)

@mattdowle
Copy link
Member

@HughParsonage This is great! I started a quick edit and it ended up being quite an expansion. Please could you check it before I pull and merge. I'll wait for you. @MichaelChirico I'll wait for you too since you commented above.

@HughParsonage
Copy link
Member Author

HughParsonage commented Sep 27, 2017

I decided to put this part in Details as Matt's extra additions were important but a bit too lengthy for the Description (you couldn't see the Usage section with it in). Also meant this part of the documentation could use less abbreviated language and hence be a bit clearer.

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@mattdowle mattdowle merged commit 3f28c89 into Rdatatable:master Sep 27, 2017
@mattdowle
Copy link
Member

Yep - great!
( I meant to squash as I merged this one. The merge button is sticky from its last setting and I just pressed it. I'll leave it and move on this time, but I'll remember next time hopefully. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add note to ?setorder that character ordering sorts case, then alphabetically
4 participants